Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Extend container_is_privileged k8s rule to cover additional resource kinds #4882

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

Churro
Copy link
Contributor

@Churro Churro commented Feb 27, 2022

Proposed Changes

  • Extend the rule to cover additional resource kinds, e.g., Deployment, DaemonSet, etc.
  • New positive test case that covers privileged: true in a Deployment
  • More comprehensive description about security implications

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Feb 27, 2022

Scan submitted to Checkmarx

Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Such a great observation and refactor, @Churro 🚀 Thank you so much!

@joaoReigota1 joaoReigota1 merged commit d59c905 into Checkmarx:master Mar 2, 2022
@rafaela-soares rafaela-soares added the community Community contribution label Mar 16, 2022
@rafaela-soares rafaela-soares added the query New query feature label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants